[FFmpeg-devel] [PATCH 2/4] pan: add channel mapping capability.

[Clément Bœsch]

On Mon, Jan 23, 2012 at 03:05:53PM +0100, Nicolas George wrote:
> Le quartidi 4 pluviôse, an CCXX, Clément Bœsch a écrit :
> > I meant "remap == gains are pure"; remap being opposed to panning by its
> > purity.
> 
> But gains are pure... what? Pure water? Pure integers?
> 

Gains are binary, 0 or 1, the perfect numbers. And since there is a
choosen One per each channel, we reach the purity of The Matrix.

[...]
> >  - bumped lavfi micro
> 
> Beware, git rebase will silently assume the hunk has been cherry-picked
> instead of showing a conflict.
> 

I'll be careful :)

[...]
> > +    // gains are pure, init the channel mapping
> > +    if (pan->pure_gains) {
> > +
> > +        // sanity check; can't be done in query_formats since the inlink
> > +        // channel layout is unknown at that time
> > +        if (pan->nb_input_channels >= SWR_CH_MAX) {
> 
> I believe nb_input_channels == SWR_CH_MAX should be accepted.
> 

It seems I never learn from my mistakes... fixed locally.

[...]
> > +static void filter_samples_channel_mapping(struct PanContext *pan,
> 
> 
> struct is not necessary (but not evil either).
> 

Removed.

> > +                                           AVFilterBufferRef *outsamples,
> > +                                           AVFilterBufferRef *insamples,
> > +                                           int n)
> > +{
> > +    swr_convert(pan->swr, outsamples->data, n, (void *)insamples->data, n);
> > +}
> >  
> > -static void filter_samples(AVFilterLink *inlink, AVFilterBufferRef *insamples)
> > +static void filter_samples_panning(struct PanContext *pan,
> 
> Idem.
> 

Also removed.

[...]
> 
> It looks good. Unless someone else has remarks, I believe it can be applied.
> And no need to send another patch just to replace ">=" by ">" or remove
> struct.
> 

I'll push the patchset in a few hours.

> Thanks for your work.
> 

Thank you for your time spent on the review :)

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120124/869edcc5/attachment.asc>