[FFmpeg-devel] [PATCH] Demux all parts of concatenated H.264.

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Jan 28 22:08:18 CET 2012


On Sun, Jan 22, 2012 at 05:14:27PM +0100, Reimar Döffinger wrote:
> On Sun, Jan 22, 2012 at 05:04:08PM +0100, Michael Niedermayer wrote:
> > On Sun, Jan 22, 2012 at 02:49:14PM +0100, Reimar Döffinger wrote:
> > > On Sat, Jan 21, 2012 at 03:45:21PM +0100, Michael Niedermayer wrote:
> > > > On Sat, Jan 21, 2012 at 11:14:27AM +0100, Reimar Döffinger wrote:
> > > > > We may or may not be able to play the latter parts
> > > > > but not demuxing at all seems like the worst possible behaviour.
> > > > > Fixes playback of e.g.
> > > > > http://playlist.yahoo.com/makeplaylist.dll?sid=128114687&sdm=web&pt=rd
> > > > > As a proper solution either multiple video streams should
> > > > > be exported or side data should be used to update extradata
> > > > > if necessary.
> > > > 
> > > > what effect does this patch have on #2069
> > > > (see adc7305424187bf58516d73a368e569e9d7dcdb9) ?
> > > 
> > > I complained already back then at that issue that the "fix"
> > > consisted of changing from "plays with artefacts" to "does not play at
> > > all". I have never considered such a thing a "fix", personally I'd even
> > > call it "worse bug" though I admit that is debatable.
> > > Maybe checking whether the extradata is actually the same would work
> > > at at least not break files that played perfectly before (like above),
> > > but it seems like overkill to me.
> > 
> > If you think its better with the patch than without then please apply
> 
> I'll wait a bit to give Baptiste a chance to flame me back.
> Or maybe I or someone else even goes so far to add proper support for
> updating extradata mid-stream.

Too busy with more pressing issues, so pushed.


More information about the ffmpeg-devel mailing list