[FFmpeg-devel] [PATCH] flvdec: actually accept new extradata.

Michael Niedermayer michaelni at gmx.at
Sun Jan 29 21:00:17 CET 2012

On Sun, Jan 29, 2012 at 07:21:03PM +0100, Nicolas George wrote:
> Le decadi 10 pluviôse, an CCXX, Michael Niedermayer a écrit :
> > yes, but please see: (it was quite intentionally disabled because it
> > broke various things and fixed none)
> I briefly saw that one, but I could not make heads nor tails out of it. In
> the current code, the whole flv_queue_extradata code path is dead code, and
> that can not be right. My best guess is that there are two fixes for the
> same problem, one from you and one from libav, conflicting with each other.

I dont think the libav code works or is even complete.

> I have attached to ticket #952 a sample from Dailymotion that works with the
> libav version but not with the current ffmpeg version.

what iam seeing is that our extradata parsing code returns 0 which
causes the loop.
and the frame multithreading doesnt work with the extradata passed
mid stream
the reason why it works with the change to flvdec is that the extradata
is not passed at all anymore and it seems this file doesnt need it

> Do you still have the reference of the samples you write about there:
> >     It breaks some samples
> ?

probably i do, the trick is to find which of the files on my disk is it


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Awnsering whenever a program halts or runs forever is
On a turing machine, in general impossible (turings halting problem).
On any real computer, always possible as a real computer has a finite number
of states N, and will either halt in less than N cycles or never halt.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120129/b47a2956/attachment.asc>

More information about the ffmpeg-devel mailing list