[FFmpeg-devel] [PATCH]Implement Bluray subtitle forcing

[Michael Niedermayer]

On Sun, Jan 29, 2012 at 06:26:32PM +0100, Carl Eugen Hoyos wrote:
> On Sunday 29 January 2012 05:46:13 pm Reimar Döffinger wrote:
> > On Sun, Jan 29, 2012 at 04:42:04PM +0000, Carl Eugen Hoyos wrote:
> > > Reimar Döffinger <Reimar.Doeffinger <at> gmx.de> writes:
> > > > > +        if (!ctx->forced_subs_only ||
> > > > > ctx->presentation.objects[rect].composition & 0x40)
> > > > >          memcpy(sub->rects[rect]->pict.data[1], ctx->clut,
> > > > > sub->rects[rect]->nb_colors * sizeof(uint32_t));
> > > >
> > > > Well, I'd be in favour of having some flags in sub->rects, but
> > > > I think that would mean an API/ABI change...
> > >
> > > So may I commit?
> > 
> > I don't know if the patch is correct otherwise, I don't use
> > the option code usually.
> > I don't really see why you need the AVCodecContext in the struct
> > for example.
> 
> I thought it is needed, but it seems I was wrong.
> 
> New patch attached.
> 
> Please comment, Carl Eugen

LGTM

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The bravest are surely those who have the clearest vision
of what is before them, glory and danger alike, and yet
notwithstanding go out to meet it. -- Thucydides
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120130/cf559196/attachment.asc>