[FFmpeg-devel] [PATCH] lavd/oss: support for more than 2 channels

[Alexander Strasser]

Nicolas George wrote:
> Le sextidi 6 thermidor, an CCXX, Alexander Strasser a écrit :
> > > +    if (s->channels > 2) {
> > > +        av_log(s1, AV_LOG_ERROR, "%d channels not yet supported.\n", s->channels);
> > > +        if (is_output)
> > > +            av_log(s1, AV_LOG_ERROR, "You can add the '-ac 2' option to let ffmpeg downmix to stereo.\n");
> > > +        return AVERROR_PATCHWELCOME;
> > > +    }
> >   While your patch seems sensible. I think this is not the right place
> > for the hint on command line usage. Not sure if it is easy to implement
> > the command line usage hint outside of lavd...
> 
> I do not insist on it, but I believe it useful (I suspect the original patch
> was related to a confusion between the -channels and -ac options) and I
> really do not see any other way of implementing any other way. Considering
> that lavd is not used much, I believe the people who will actually see the
> warning are very likely to be using the ffmpeg command-line tool anyway.

  I can understand your reasoning. The only fear I have is that if someone
investigates or starts investigating some day to use lavd she might be put
off by things like that.

> Is there anyone else who cares enough and wants to give an advice?

  But I agree with you that it is not of much importance these days and
that lavd needs a lot more love. So I am OK with whatever you/others
prefer.


Thanks for considering my comment,
  Alexander