[FFmpeg-devel] [PATCH] lavfi/settb: do not modify the input reference, pass along a new modified copy

Nicolas George nicolas.george at normalesup.org
Mon Jul 30 16:29:44 CEST 2012

Le tridi 13 thermidor, an CCXX, Stefano Sabatini a écrit :
> Avoid to modify the internal properties which may be accessed by another
> filter before in the filterchain, in case that is not caching an internal
> reference and needs to access the unaltered data later after start_frame().

I think it does not work, because of that:

> +        avfilter_unref_buffer(inpicref);

A filter that accesses a ref after having given it away is bogus and
absolutely needs to be fixed.

Therefore, I think there is absolutely no need to allocate a new reference
(which is not completely cheap).

> Also improve consistency with filter_samples() of asettb, allowing a
> pending factorization.

I am all for the factorization, but doing it the other way around seems a
better idea.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120730/0694cb12/attachment.asc>

More information about the ffmpeg-devel mailing list