[FFmpeg-devel] [PATCH 3/3] two functions were declared inlinebut were referenced elsewhere

J. Bohl jbohl at jbohl.de
Thu Jun 14 01:16:16 CEST 2012


>iam a bit affraid this could cause a slowdown. did you check what
effect this change has 
>on compilers supporting the code currently ?

No, sorry I am not able to quantify the impact of this change at this
point. At least not with tangible numbers, with a quick transcoding run
(Linux x86, gcc4.6) I didn't notice a (significant) difference.
Maybe you like the attached revised patch better - having two functions,
one that is attributed inline and one for external reference.

>changing all MANGLE() to "m" will break compilation on several

Yeah, I understand this. And cluttering the code with #ifdef's would be
a mess I suppose. OK, then can't help it.

>isnt icc able to optimize this out with some command line switches ?
>under linux ICC is able to do such elimination of calls ...
>if it really doesnt work its maybe worth to report to intel if it hasnt
been reported yet. Intel 
>is likely interrested to improve ICCs dead code elimination.

Good idea, I didn't think of that. I'll check this out. I seem to
remember that it is a compatibility issue (compatibility with the
Microsoft compiler).



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-revised-patch-for-ff_get_mb_score-ff_epzs_motion_sea.patch
Type: application/octet-stream
Size: 5349 bytes
Desc: 0004-revised-patch-for-ff_get_mb_score-ff_epzs_motion_sea.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120614/a2bba6ca/attachment.obj>

More information about the ffmpeg-devel mailing list