[FFmpeg-devel] [PATCH 3/3] two functions were declaredinlinebut were referenced elsewhere

[Michael Niedermayer]

On Fri, Jun 15, 2012 at 02:31:10AM +0200, Michael Niedermayer wrote:
> On Thu, Jun 14, 2012 at 11:39:07PM +0200, J. Bohl wrote:
> > Hi,
> > 
> > I read through these articles
> > http://www.greenend.org.uk/rjk/tech/inline.html and
> > http://stackoverflow.com/questions/216510/extern-inline - and got even
> > more confused.
> > Well, the my state of mind is now:
> > - in C99 "extern inline" creates an out-of-line function (=externally
> > visible)
> > - GCC before 4.3 treats "inline" the same way (creates always an
> > out-of-line function as well)
> > 
> > In addition, every compiler that compiles/links the current code without
> > a linker error obviously treats "inline" as "create an out-of-line
> > function as well".
> > 
> > So I arrived at:
> > 
> > #ifndef av_extern_inline
> > #if defined(__INTEL_COMPILER) ||  defined(__GNUC_STDC_INLINE__)
> > #    define av_extern_inline extern inline
> > #else
> > #    define av_extern_inline inline
> > #endif
> > #endif
> 
> applied

reverted again due to compilation failure of ICC:

http://fate.ffmpeg.org/log.cgi?time=20120615060729&log=compile&slot=x86_64-linux-gnu-icc-2011.4.191

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120615/44cf37de/attachment.asc>