[FFmpeg-devel] [PATCH 3/3] two functions weredeclaredinlinebutwere referenced elsewhere

[J. Bohl]

Hello,

>are all versions of ICL compatible with the C99 syntax ?
>if not this maybe needs a version number check

I am sorry, I don't know and I couldn't find out. The only version I
have at hand (and are sure about it) is ICL12.10. This topic is not
covered in the documentation, at least I didn't find anything (e.g. no
switch to tweak things).
On the other hand - as far as my understanding goes, ffmpeg currently
does not build with ICL - at least not right out of the box. So, I'd
think we won't break anything.

With the information at hand the version check would look like this:

#if defined(__ICL) && __ICL >= 1210 || defined(__GNUC_STDC_INLINE__)

Regards,

Juergen

-----Original Message-----
From: ffmpeg-devel-bounces at ffmpeg.org
[mailto:ffmpeg-devel-bounces at ffmpeg.org] On Behalf Of Michael
Niedermayer
Sent: Saturday, June 16, 2012 12:55 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH 3/3] two functions
weredeclaredinlinebutwere referenced elsewhere

On Sat, Jun 16, 2012 at 12:40:40AM +0200, J. Bohl wrote:
> Hi,
> 
> I apologize for the inconvenience. I am on the verge of giving up, and

> do not want to cause more trouble.

its not really causing troubble, the code we have is strictly speaking
not correct even if all currently supported compilers handle it.


> OK, one last attempt: obviously icc (Linux) uses pre-4.3-GCC sematic, 
> whereas icl (Windows) uses C99 sematic. So we would have to 
> distinguish between icl and icc, and one way to do it is using the 
> predefined macro __ICL versus __ICC (just verified that, __ICL is 
> _not_ defined with icc and vice versa).
> So, we have
> 
> #if defined(__ICL) ||  defined(__GNUC_STDC_INLINE__)

are all versions of ICL compatible with the C99 syntax ?
if not this maybe needs a version number check

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established
authorities are wrong. -- Voltaire