[FFmpeg-devel] [PATCH] lavf: add a real SRT muxer.

Nicolas George nicolas.george at normalesup.org
Thu Jun 21 19:33:27 CEST 2012

Le quartidi 4 messidor, an CCXX, Clément Bœsch a écrit :
> The point was just to avoid the write_ts assignment each time, like if it
> was suggesting it could change between srt_write_packet() calls (or can
> it?).

It is suggesting nothing of the sort, it is just reducing code duplication.
Nobody would have said anything if I had included the same test in both.

> If it detects the "<num>\n... --> ..." form in the packet, it could assume
> one mode or another. That might sound hacky though :)

And also fragile. And even bogus: a subtitle text is allowed to look exactly
like a SRT timestamp.

If you or others have no objections, I shall push the patch as is soon.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120621/8aa98ec8/attachment.asc>

More information about the ffmpeg-devel mailing list