[FFmpeg-devel] [PATCH] lavc/pcm: clarify error message from pcm_decode_frame()

Stefano Sabatini stefasab at gmail.com
Fri Jun 22 23:21:44 CEST 2012


Extend/clarify an error message in case of invalid packet size, and
return a proper error message instead of -1.
Improve debuggability.
---
 libavcodec/pcm.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c
index c72b200..826267f 100644
--- a/libavcodec/pcm.c
+++ b/libavcodec/pcm.c
@@ -293,8 +293,10 @@ static int pcm_decode_frame(AVCodecContext *avctx, void *data,
 
     if (n && buf_size % n) {
         if (buf_size < n) {
-            av_log(avctx, AV_LOG_ERROR, "invalid PCM packet\n");
-            return -1;
+            av_log(avctx, AV_LOG_ERROR,
+                   "Invalid PCM packet, data has size %d but at least a size of %d was expected\n",
+                   buf_size, n);
+            return AVERROR_INVALIDDATA;
         } else
             buf_size -= buf_size % n;
     }
-- 
1.7.5.4



More information about the ffmpeg-devel mailing list