[FFmpeg-devel] [PATCH] mxf: micro patch - mxf parsing

[Michael Niedermayer]

On Tue, Mar 20, 2012 at 11:46:59AM +0100, Tomas Härdin wrote:
> On Mon, 2012-03-19 at 17:06 +0200, Alex Zhukov wrote:
> > On Mon, Mar 19, 2012 at 4:02 PM, Alex Zhukov <zhukov.alex at gmail.com> wrote:
> > > On Mon, Mar 19, 2012 at 2:12 PM, Michael Niedermayer <michaelni at gmx.at> wrote:
> > >> On Fri, Mar 16, 2012 at 08:47:59PM +0200, Alex Zhukov wrote:
> > >>> I thought this fix was not worth creating the full on patch
> > >>> make fate fails on adpcm_ima_qt for me so did not test
> > >>>
> > >>> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> > >>> index 3d99ea7..e2eea95 100644
> > >>> --- a/libavformat/mxfdec.c
> > >>> +++ b/libavformat/mxfdec.c
> > >>> @@ -1877,6 +1877,7 @@ static int mxf_read_header(AVFormatContext *s)
> > >>>              /* next partition pack - keep going, seek to previous
> > >>> partition or stop */
> > >>>              if(mxf_parse_handle_partition_or_eof(mxf) <= 0)
> > >>>                  break;
> > >>> +            continue;
> > >>>          }
> > >>
> > >> this patch seems to break fate-seek-lavf_mxf
> > >
> > > yes it does
> > > let me figure out why
> > 
> > I was trying to fix ticket https://ffmpeg.org/trac/ffmpeg/ticket/1099
> > Maybe mxf maintainer could take a look.
> 
> Here's a better patch that fixes the issue and doesn't break FATE.
> 
> /Tomas

>  mxfdec.c |    3 +++
>  1 file changed, 3 insertions(+)
> 48576a5c49e36784b943176cf172cf260d3feb8a  0001-mxfdec-Only-parse-next-partition-pack-if-parsing-for.patch
> From 0e363db80cb856b2c796e585f6f3804596179a66 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Tomas=20H=C3=A4rdin?= <tomas.hardin at codemill.se>
> Date: Tue, 20 Mar 2012 11:03:48 +0100
> Subject: [PATCH] mxfdec: Only parse next partition pack if parsing forward
> 
> This fixes ticket #1099.

applied

Thanks

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Complexity theory is the science of finding the exact solution to an
approximation. Benchmarking OTOH is finding an approximation of the exact
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120320/070b80fd/attachment.asc>