[FFmpeg-devel] [PATCH 4/5] src_buffer: implement av_buffersrc_add_frame.

Nicolas George nicolas.george at normalesup.org
Thu May 3 20:23:08 CEST 2012

Le quintidi 15 floréal, an CCXX, Clément Bœsch a écrit :
> I know it's already approved, but this can be simplified with a
> avfilter_get_buffer_ref_from_frame() (see comment on patch 1/5).

See my other message.

> Also another commit to rename picref into ref or bufref would be welcome I
> guess.

There are inconsistencies and bad naming all over the place, because the
different codes that were merged had different conventions. Stefano pointed
it out too.

In the first round, I kept as much original code as possible, but sure,
patches to make all this consistent would be useful once everything is

> PS: sorry if these comments have already been raised, I don't remember
> them so just in case...

No problem.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20120503/6a8051df/attachment.asc>

More information about the ffmpeg-devel mailing list