[FFmpeg-devel] lavfi: Add fps filter.

Andrey Utkin andrey.krieger.utkin at gmail.com
Fri May 4 12:53:38 CEST 2012

2012/5/4 Robert Nagy <ronag89 at gmail.com>:
> Good idea?

Definitely yes.
I have implemented such a filter for a company's non-distributable
usage (not a trivial thing, and it's under NDA, thus sorry but can't
disclose), it's quite handy to have.
Please post patches using 'git send-email', makes it easier to comment.

> auto fps = reinterpret_cast<FPSContext*>(link->src->priv);

Definitely not a C expression. Please stick with C.

Please add into your patch also respective changes into makefiles, to
make it compile from ffmpeg sources tree.
Did you actually test it for both increase and resuction of FPS?
Did you test it for absense of memory leaks? This is probable issue as
lavfi buffers are reference-counted.
(I haven't dig into your algorithm.)

Andrey Utkin

More information about the ffmpeg-devel mailing list