[FFmpeg-devel] [PATCH 06/10] asrc_abuffer: deprecate av_asrc_buffer_* functions.

Stefano Sabatini stefasab at gmail.com
Sat May 5 23:54:07 CEST 2012


On date Saturday 2012-05-05 10:22:34 +0200, Nicolas George encoded:
> 
> Signed-off-by: Nicolas George <nicolas.george at normalesup.org>
> ---
>  libavfilter/asrc_abuffer.h |    9 +++++++++
>  libavfilter/src_buffer.c   |    4 ++++
>  2 files changed, 13 insertions(+)
> 
> 
> Putting attribute_deprecated in the previous line makes the patch more
> readable, and avoids overly long lines and broken indent.
> 
> 
> diff --git a/libavfilter/asrc_abuffer.h b/libavfilter/asrc_abuffer.h
> index 4352c74..ebf55fd 100644
> --- a/libavfilter/asrc_abuffer.h
> +++ b/libavfilter/asrc_abuffer.h
> @@ -38,7 +38,10 @@
>   * @param planar flag to indicate if audio data is planar or packed
>   * @param pts presentation timestamp of the audio buffer
>   * @param flags unused
> + *
> + * @deprecated use av_buffersrc_add_ref() instead.

Nit: "Use", depending on consistency/doxygen rendering.

[...]

LGTM otherwise.
-- 
FFmpeg = Frenzy Fostering Majestic Perennial Enigmatic Ghost


More information about the ffmpeg-devel mailing list