[FFmpeg-devel] [PATCH] Fix warnings about int64 to int32 conversion

[Reimar Döffinger]

On 16 May 2012, at 01:07, Michael Bradshaw <mbradshaw at sorensonmedia.com> wrote:

> Attached patch fixes the following two warnings about converting from
> int64 to int32:
> 
> 1>ffmpeg_latest\include\libavutil\common.h(174) : warning C4244:
> 'return' : conversion from 'int64_t' to 'int32_t', possible loss of
> data
> 1>ffmpeg_latest\include\libavutil\common.h(233) : warning C4244:
> 'argument' : conversion from 'uint64_t' to 'uint32_t', possible loss
> of data

First, if the compiler generates a warning for the >> 32 case it is just being stupid, there can be no loss of data in that case.
Second, that warning is generally just nonsense and I don't really see much point in cluttering the code with it, you can just disable the warning. IMHO.