[FFmpeg-devel] [PATCH] ffprobe: make c_escape_str() documentation more terse

Stefano Sabatini stefasab at gmail.com
Tue May 29 01:05:57 CEST 2012


On date Sunday 2012-05-27 09:53:48 +0200, Clément Bœsch encoded:
> On Sun, May 27, 2012 at 01:32:08AM +0200, Stefano Sabatini wrote:
> > Avoid to specify implementation details, better to check the code for
> > that.
> > ---
> >  ffprobe.c |    3 +--
> >  1 files changed, 1 insertions(+), 2 deletions(-)
> > 
> > diff --git a/ffprobe.c b/ffprobe.c
> > index 1f3497b..5fb4c47 100644
> > --- a/ffprobe.c
> > +++ b/ffprobe.c
> > @@ -497,8 +497,7 @@ static const Writer default_writer = {
> >  /* Compact output */
> >  
> >  /**
> > - * Escape \n, \r, \f, \b, \\ and sep characters contained in s, and
> > - * print the resulting string.
> > + * Apply C-language-like string escaping.
> >   */
> >  static const char *c_escape_str(AVBPrint *dst, const char *src, const char sep, void *log_ctx)
> >  {
>

> What about simplifying the documentation description as well? (which is
> also a bit verbose for nothing).

Patches are welcome ;-). 

> LGTM.

Applied.
-- 
FFmpeg = Freak Formidable Muttering Peaceful Elected Guru


More information about the ffmpeg-devel mailing list