[FFmpeg-devel] [PATCH]Recognize

[Clément Bœsch]

On Fri, Nov 02, 2012 at 07:21:14PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > > >              //Read QT version 1 fields. In version 0 these do not exist.
> > > >              av_dlog(c->fc, "version =%d, isom =%d\n",version,c->isom);
> > > > -            if (!c->isom) {
> > > > +            if (!c->isom ||
> > > > +                strstr(av_dict_get(c->fc->metadata, "compatible_brands", 
> NULL,  AV_DICT_MATCH_CASE)->value,
> > "qt  ")) {
> > > >                  if (version==1) {
> > > >                      sc->samples_per_frame = avio_rb32(pb);
> > > >                      avio_rb32(pb); /* bytes per packet */
> > > 
> > > Might be ok.
> > 
> > Is this special case specific to this use of isom or could isom
> > itself be changed based on the existence of qt in compatible_brands
> > ?
> 
> You mean like my original patch (with strstr)?
> Or do I misunderstand?
> 

No I meant the major brand, not the compatible brand list; IIRC the sample
on the ticket has "JUNK" has major brand. "This file is junk, and is
compatible with QuickTime".

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121102/3bb8867d/attachment.asc>