[FFmpeg-devel] [PATCH 3/4] lavu/opt: implement av_opt_get_key_value().

Nicolas George nicolas.george at normalesup.org
Sat Nov 3 17:06:46 CET 2012

Le tridi 13 brumaire, an CCXXI, Stefano Sabatini a écrit :
> maybe you can use directly ropts, rkey, rval

I do not want to alter their value if the function fails.

> > +    char *av_uninit(parsed_key), *av_uninit(value);
> What's this useful for?

My version of gcc is not smart enough to understand that they will be
initialized after the "if (ret < 0) return" test.

> Possibly mention what "r" stands for (return or whatever).

I consider that in such a case the asterisk marking them as pointer makes
that obvious.

> Final dot missing

Will fix before pushing.

Thanks for the review.

  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121103/86e1b306/attachment.asc>

More information about the ffmpeg-devel mailing list