[FFmpeg-devel] [PATCH 3/4] lavu/opt: implement av_opt_get_key_value().
nicolas.george at normalesup.org
Sat Nov 3 17:06:46 CET 2012
Le tridi 13 brumaire, an CCXXI, Stefano Sabatini a écrit :
> maybe you can use directly ropts, rkey, rval
I do not want to alter their value if the function fails.
> > + char *av_uninit(parsed_key), *av_uninit(value);
> What's this useful for?
My version of gcc is not smart enough to understand that they will be
initialized after the "if (ret < 0) return" test.
> Possibly mention what "r" stands for (return or whatever).
I consider that in such a case the asterisk marking them as pointer makes
> Final dot missing
Will fix before pushing.
Thanks for the review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel