[FFmpeg-devel] [PATCH 4/4] cmdutils: allow to set the report file name.
nicolas.george at normalesup.org
Sat Nov 3 17:12:07 CET 2012
Le tridi 13 brumaire, an CCXXI, Stefano Sabatini a écrit :
> I'm not really sure about this, having
> looks more extensible, but I don't know if we'll need to add more
What exactly are you not sure about? One of the concerns when writing this
is that some people probably already use the FFREPORT environment variable,
as it is currently used: setting it to anything enables the report. We would
not want people who have set FFREPORT=1 to get all their reports in a file
called "1". And I think using several environment variables is annoying.
There is IMHO a very low probability of someone having set their FFREPORT
environment variable to anything starting with "file=" by coincidence.
> Also if you want to really support
> FFREPORT=key1=val1:key2=val2... then the usual considerations on
> escaping should be applied (think about C:\Windows\file), which
> complicates the interface for the user.
I have not actually tested, but since it is handled using the very same
functions as the options parsing algorithm, it should already be taken care
If the above satisfies you, I will push this soon.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel