[FFmpeg-devel] [PATCH] lavc/aac: fix shared build failures with MSVC.

[Michael Niedermayer]

On Fri, Nov 09, 2012 at 12:09:56AM +0100, Clément Bœsch wrote:
> ---
>  libavcodec/aacenc.c       | 9 ++++++++-
>  libavcodec/libvo-aacenc.c | 9 ++++++++-
>  2 files changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/libavcodec/aacenc.c b/libavcodec/aacenc.c
> index fe5b84d..22962a3 100644
> --- a/libavcodec/aacenc.c
> +++ b/libavcodec/aacenc.c
> @@ -811,6 +811,13 @@ static const AVClass aacenc_class = {
>      LIBAVUTIL_VERSION_INT,
>  };
>  
> +/* duplicated from avpriv_mpeg4audio_sample_rates to avoid shared build
> + * failures */

please also add such a comment to avpriv_mpeg4audio_sample_rates
or maybe move the 2 lines of sample rates in a header and inlcude that.

I naively assume that theres no clean solution without duplication
...
if thats wrong and there is a nicer solution that of course would be
preferable


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 1
"Used only once"    - "Some unspecified defect prevented a second use"
"In good condition" - "Can be repaird by experienced expert"
"As is" - "You wouldnt want it even if you were payed for it, if you knew ..."
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121109/77d97e6c/attachment.asc>