[FFmpeg-devel] [PATCH] lavc/aac: fix shared build failures with MSVC.
h.leppkes at gmail.com
Fri Nov 9 09:38:36 CET 2012
On Fri, Nov 9, 2012 at 9:31 AM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Hendrik Leppkes <h.leppkes <at> gmail.com> writes:
> > The problem is that the dllimport marker is always present,
> > so even if you use a datasymbol in the same library where
> > it lives, the compiler/linker make it an imported symbol,
> > which means its not constant, and thus cannot be used as a
> > static initializer.
> So is the patch ok?
The patch does fix the issue. If duplicating is the best course of
action... It certainly is the easiest route. Considering these values most
likely never change, its OK for me.
In case they do ever change, there should probably be a comment on top of
the original avpriv_ structure indicating that other spots may need
More information about the ffmpeg-devel