[FFmpeg-devel] [PATCH] lavfi: store and propagate number of channels information in audio buffer properties

Stefano Sabatini stefasab at gmail.com
Sun Nov 11 13:54:50 CET 2012


On date Sunday 2012-11-11 04:58:30 +0100, Michael Niedermayer encoded:
> On Sun, Nov 11, 2012 at 04:46:13AM +0100, Michael Niedermayer wrote:
[...]
> > > i think at the end of the struct is a safer
> > > and minor should be bumped
> > > 
> > > otherwise LGTM
> > 
> > ping
> > 
> > ive today fixed a security issue that a design based on this patch
> > would have never made possible. Also currently we cannot transcode
> > files with more than 8 channels, and to transcode a file without a
> > layout that can be represented in the layout mask a random standard
> > layout must be assigned to it, that is just wrong and also might
> > produce damaged files containing incorrect layouts.
> > 
> > so this patch should not be left rotting ...
> 
> nicolas, stefano, ubitux any comments ?

Patch updated.

I didn't push the patch because there was no evidence that it was
useful (indeed channels info is redundant with channel layout). Patch
passes FATE here, push it or I'll do it tomorrow or later.
-- 
FFmpeg = Foolish Faithless Magical Prodigious Ecletic Genius
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavfi-store-and-propagate-number-of-channels-informa.patch
Type: text/x-diff
Size: 3022 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121111/3871c9a5/attachment.bin>


More information about the ffmpeg-devel mailing list