[FFmpeg-devel] [PATCH 1/3] lavu/bprint: implement av_bprint_strftime().
nicolas.george at normalesup.org
Sun Nov 11 18:59:18 CET 2012
Le decadi 20 brumaire, an CCXXI, Clément Bœsch a écrit :
> I think you meant "due *to*"
> Could you be more specific about what the user is supposed to do, or what
> unexpected behaviour could happen?
I expanded a bit the doc.
> Also, the function doesn't return any
> success/failure status, is that a good idea given the "poor design" of the
> function called within?
I added some more code to try very hard to produce something useful. Now it
will only actually fail if the expanded date-time fits neither in the rest
of the bprint buffer nor in 1k of local stack. For a simple date and time,
this is wide. And if it fails, the bprint buffer will correctly be marked as
New patch sent. Thanks for the review.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: Digital signature
More information about the ffmpeg-devel