[FFmpeg-devel] [PATCH] brender_pix: a new image decoder

Aleksi Nurmi aleksi.nurmi at gmail.com
Thu Nov 15 20:16:05 CET 2012

2012/11/15 Carl Eugen Hoyos <cehoyos at ag.or.at>:
> Please define an id with MKBETAG for AV_CODEC_ID_BRENDER_PIX.


> I would suggest to move the four lines below the license
> header in a separate comment.
> (And perhaps shorten the lines a bit.)


> Please use a license header with "FFmpeg".


> Are you sure that there is no transparency information?
> I am especially surprised because GRAY8A is supported.
> I wanted to test, but none of the samples you
> provided contains 32bit pixels.

My apologies, here's an updated collection:

I'm fairly certain of it: RGBX is in a list of pixel formats of the
BRender API, before RGBA (probably format 8). RGBX is apparently used
in palettes.

Also, I changed the name of the format to GRAY8A. I managed to miss that one.

> It's preferred to move "{" at the end of the condition.
> (Feel free to ignore, same below.)


> This could be alphabetically ordered.

The list isn't, but I put it along with the second group of Ps.

I'll post a second version of the patch soon.

More information about the ffmpeg-devel mailing list