[FFmpeg-devel] [PATCH 2/3] lavf/srtdec: do not put line break event separator into packet.
ubitux at gmail.com
Thu Nov 15 22:42:11 CET 2012
On Sun, Nov 11, 2012 at 12:44:17AM +0100, Clément Bœsch wrote:
> The muxer add them automatically, so this avoid having a bunch of line
> breaks all over the output files. One '\n' is still kept/added for two
> - that line break can be considered part of the subtitle event, while
> the second one (which is now trimmed) is an event separator.
> - the lavc subrip decoder seems to have trouble with line ending
> abruptly (it doesn't flush correctly the tags). This bug is harmless
> but should be fixed; though, this doesn't look like a trivial change.
> When this bug gets fixed, we can consider removing the '\n' at the
> end of the packet.
> The 2048B buffer limit was also removed while moving to AVBPrint API.
> Note that this doesn't really matter since the decoder is limited as
> libavformat/srtdec.c | 65 ++++++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 53 insertions(+), 12 deletions(-)
Note that I'd like to move on on this, since I plan to send more related
patches, like fixing a related issue in lavc/srtenc.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 490 bytes
Desc: not available
More information about the ffmpeg-devel