[FFmpeg-devel] [PATCH] lavf/mp3enc: make sure the header is valid before writing audio pkt.

[Michael Niedermayer]

On Fri, Nov 16, 2012 at 09:24:47AM +0100, Clément Bœsch wrote:
> From: Clément Bœsch <clement.boesch at smartjog.com>
> 
> An invalid header can lead avpriv_mpegaudio_decode_header() to overread
> and/or div by zero.
> ---

> Should we write the packet anyway instead of dropping it completely?

i suspect it would be better to write them and print a warning

patch LGTM otherwise


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 3
"Rare item" - "Common item with rare defect or maybe just a lie"
"Professional" - "'Toy' made in china, not functional except as doorstop"
"Experts will know" - "The seller hopes you are not an expert"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121116/7b702e65/attachment.asc>