[FFmpeg-devel] [PATCH] cafdec: return right code if EOF is reached

[Paul B Mahol]

On 11/20/12, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Paul B Mahol <onemda <at> gmail.com> writes:
>
>> +++ b/libavformat/cafdec.c
>> @@ -343,7 +343,7 @@ static int read_packet
>>      int64_t left      = CAF_MAX_PKT_SIZE;
>>
>>      if (url_feof(pb))
>> -        return AVERROR(EIO);
>> +        return AVERROR_EOF;
>
> On which sample did you test this?
> (I used http://samples.ffmpeg.org/A-codecs/caf/testcaf3.caf )

I did not tested anything just found this non-logical code which
is there from begining.
It makes sense to return AVERROR_EOF in such case.
That is what most (if not all) dexmuxers return.

It is ok if it does not fix your sample.