[FFmpeg-devel] [PATCH] lavfi/drawtext: add support to expansion of generic expressions

Nicolas George nicolas.george at normalesup.org
Tue Nov 27 20:42:45 CET 2012

Le septidi 7 frimaire, an CCXXI, Stefano Sabatini a écrit :
> This is a post-configuration error, so can't be detected during
> configuration, and I felt a bit uneasy about aborting after that
> stage.

Other kind of errors, such a spelling mistake in the function name, have
that kind of effect, so there is not much scruple to have.

>	 Also note that the function *is* returning an error,

Indeed, my bad.

>							      but it is
> ignored by the higher-level function.

True. This should probably be fixed, but it is unrelated.

For now, I would just suggest to replace AV_LOG_WARNING by AV_LOG_ERROR and
to drop the expr_func_warning_done bit, because having that kind of
safeguard for that particular error and not all the similar errors that can
happen looks rather silly.

Apart from that, I think you can go ahead and push.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121127/b1d31420/attachment.asc>

More information about the ffmpeg-devel mailing list