[FFmpeg-devel] [PATCH 1/2] Fix DPX decoder Rewrite the DPX decoder to work with provided sample DPXs

Georg Lippitsch georg.lippitsch at gmx.at
Fri Oct 5 01:14:05 CEST 2012


Am 05.10.2012, 00:14 Uhr, schrieb Michael Niedermayer <michaelni at gmx.at>:

> i dont remember the case you refer to so i cant comment on that,
> but in general
>
> patches should be self contained, that is 1 bugfix = 1 patch,
> 1 feature = 1 patch
> when in doubt its probably better to split, it can help with
> git bisect later.

I'm referring to: <20120502000050.GH2246 at arborea>
(Subject: [PATCH] FireWire DV/HDV input device using libiec61883)

Since DPX is a relatively simple format, I'd consider "DPX decoding" as  
one feature, and DPX encoding as another, so IMHO it's ok what I did.
But of course I can split them into more parts if you want.


Georg


More information about the ffmpeg-devel mailing list