[FFmpeg-devel] [PATCH] fate/ffprobe: add some stream metadata.

[Clément Bœsch]

On Thu, Sep 27, 2012 at 10:39:13AM +0200, Stefano Sabatini wrote:
> On date Thursday 2012-09-27 09:50:58 +0200, Clément Bœsch encoded:
> > From: Clément Bœsch <clement.boesch at smartjog.com>
> > 
> > ---
> >  tests/Makefile                 |    2 ++
> >  tests/ref/fate/ffprobe_compact |   62 ++++++++++++++++-----------------
> >  tests/ref/fate/ffprobe_csv     |   62 ++++++++++++++++-----------------
> >  tests/ref/fate/ffprobe_default |   67 ++++++++++++++++++-----------------
> >  tests/ref/fate/ffprobe_flat    |   67 ++++++++++++++++++-----------------
> >  tests/ref/fate/ffprobe_ini     |   71 ++++++++++++++++++++-----------------
> >  tests/ref/fate/ffprobe_json    |   75 ++++++++++++++++++++++------------------
> >  tests/ref/fate/ffprobe_xml     |   67 ++++++++++++++++++-----------------
> >  8 files changed, 250 insertions(+), 223 deletions(-)
> > 
> > diff --git a/tests/Makefile b/tests/Makefile
> > index 68620006..f13bc7e 100644
> > --- a/tests/Makefile
> > +++ b/tests/Makefile
> > @@ -34,6 +34,8 @@ tests/data/ffprobe-test.nut: ffmpeg$(HOSTEXESUF) | tests/data
> >  	$(M)./$< \
> >          -f lavfi -i "aevalsrc=sin(400*PI*2*t)::d=0.125[out0]; testsrc=d=0.125[out1]; testsrc=s=100x100:d=0.125[out2]" \
> >          -f ffmetadata -i $(SRC_PATH)/tests/test.ffmeta \
> 
> > +        -metadata:s:1 title=foobar -metadata:s:1 duration_ts=field-and-tags-conflict-attempt \
> > +        -metadata:s:0 E=MC2 \
> 
> I'd prefer to add these to test.ffmeta and use the -map_metadata
> option.
> 

I admit I was lazy trying to figure out how to achieve that. Changed.

> This way we test also the ffmetadata demuxer, -map_metadata and we
> keep all the metadata things in a single file, which looks more
> consistent (and workaround Windows commandline Unicode glitches).
> 

Yup. And I took the opportunity to add a ²

> Should be good otherwise, thanks.

Applied with the requested change.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121008/340486bb/attachment.asc>