[FFmpeg-devel] [PATCH] lavc/utils: provide more feedback in case of experimental codec

[Stefano Sabatini]

On date Sunday 2012-10-21 14:59:54 +0200, Michael Niedermayer encoded:
> On Sun, Oct 21, 2012 at 11:27:25AM +0200, Stefano Sabatini wrote:
> > On date Saturday 2012-10-20 17:39:57 +0200, Michael Niedermayer encoded:
> > > On Sat, Oct 20, 2012 at 02:54:02PM +0200, Stefano Sabatini wrote:
> > > > ---
> > > >  libavcodec/utils.c |    5 ++++-
> > > >  1 files changed, 4 insertions(+), 1 deletions(-)
> > > > 
> > > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c
> > > > index 5e9f38e..ac43843 100644
> > > > --- a/libavcodec/utils.c
> > > > +++ b/libavcodec/utils.c
> > > > @@ -888,7 +888,10 @@ int attribute_align_arg avcodec_open2(AVCodecContext *avctx, const AVCodec *code
> > > >  
> > > >      if (codec->capabilities & CODEC_CAP_EXPERIMENTAL)
> > > >          if (avctx->strict_std_compliance > FF_COMPLIANCE_EXPERIMENTAL) {
> > > > -            av_log(avctx, AV_LOG_ERROR, "Codec is experimental but experimental codecs are not enabled, try -strict -2\n");
> > > > +            av_log(avctx, AV_LOG_ERROR,
> > > > +                   "Codec %s is experimental but experimental codecs are not enabled: "
> > > > +                   "try the \"strict\" option with value \"experimental\"\n",
> > > > +                   codec->name);
> > > 
> > 
> > > do all user applications support named values ?
> > 
> > I don't know all user applications.
> > 
> > > if not removing -2, would a problem for their users
> > 
> > Possible alternatives:
> > try the "strict" option with value "experimental" or -2
> > try the "strict" option with value "experimental" or FF_COMPLIANCE_EXPERIMENTAL
> > 
> > I'm for the latter.
> 
> an application using atoi() will not be able to use either.
> 
> i suggest 
> 'try -strict %d\n", FF_COMPLIANCE_EXPERIMENTAL)'

Pushed this variant.
-- 
FFmpeg = Fantastic and Fanciful Magnificient Practical Exxagerate Gadget