[FFmpeg-devel] [PATCH] add QT CC track mux support

[Jason Livingston]

On Oct 21, 2012, at 10:02 AM, Carl Eugen Hoyos <cehoyos at ag.or.at>
 wrote:

> Your patch contains a lot of trailing whitespace 
> that cannot be committed to the FFmpeg repository 
> (it would reject it), consider using tools/patcheck 
> to find all occurrences.

Hi Carl, thanks for the review.  I think I have fixed this, and all of the other formatting issues mentioned, with the attached patch.  I ran tools/patcheck and I got some messages about "egrep: empty (sub)expression", maybe because I'm running it on Mac OSX, but it no longer complains about whitespace or bracket issues.

> 
>> +    av_log(avctx, AV_LOG_VERBOSE, "Not yet implemented.\n");
> 
> Then why is the file there at all?
> (Sorry if I miss something obvious.)
> 

The codec needs to exist so it can be opened, even if you never call decode/encode on a packet.  Maybe the decoder is not needed when using -codec copy?  But it seems the encoder is, otherwise avcodec_find_encoder(AV_CODEC_ID_EIA_608) returns NULL.  I could omit the decoder if that is better (can always add it as a separate patch if needed).

Thanks,
Jason

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-QT-CC-track-mux-support.patch
Type: application/octet-stream
Size: 7894 bytes
Desc: 0001-Add-QT-CC-track-mux-support.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20121022/730c4939/attachment.obj>