[FFmpeg-devel] [PATCH] lavf/flvenc: apply various log fixes/clarifications

[Stefano Sabatini]

On date Thursday 2012-09-06 15:17:25 +0200, Clément Bœsch encoded:
> On Thu, Sep 06, 2012 at 03:11:40PM +0200, Stefano Sabatini wrote:
> > Should improve user feedback in case of errors.
> > ---
> >  libavformat/flvenc.c |   27 ++++++++++++++++-----------
> >  1 files changed, 16 insertions(+), 11 deletions(-)
[...] 
> This part LGTM
> 
> > @@ -488,7 +492,8 @@ static int flv_write_packet(AVFormatContext *s, AVPacket *pkt)
> >                  return ret;
> >      } else if (enc->codec_id == AV_CODEC_ID_AAC && pkt->size > 2 &&
> >                 (AV_RB16(pkt->data) & 0xfff0) == 0xfff0) {
> > -        av_log(s, AV_LOG_ERROR, "malformated aac bitstream, use -absf aac_adtstoasc\n");
> > +        av_log(s, AV_LOG_ERROR, "Malformated AAC bitstream detected: "
> > +               "use audio bistream filter 'aac_adtstoasc' to fix it\n");
> >          return AVERROR_INVALIDDATA;
> >      }
> 
> I think it's better to provide the copy-paste-me option so the user
> doesn't wonder how to set that option.

What about:
Malformated AAC bitstream detected: use audio bistream filter
'aac_adtstoasc' to fix it (use '-absf aac_adtstoasc' option with ffmpeg)

or maybe "-bsf:a aac_adtstoas"
-- 
FFmpeg = Funny and Formidable Multipurpose Portable Educated God