[FFmpeg-devel] [PATCH 2/2] dsputil/me/pixels: Actually use av_restrict

Hendrik Leppkes h.leppkes at gmail.com
Sat Sep 8 17:37:42 CEST 2012


On Sat, Sep 8, 2012 at 5:33 PM, Michael Niedermayer <michaelni at gmx.at>wrote:

> On Sat, Sep 08, 2012 at 08:35:39AM -0400, Derek Buitenhuis wrote:
> > On 07/09/2012 4:19 PM, Michael Niedermayer wrote:
> > > i wonder, isnt it simpler and cleaner if these get replaced by that
> > > msvc wraper script ?
> > > or was there some other platform/case that needs these ?
> >
> > I think there is a tentative patch for this in the converter somewhere.
> I think it
> > is intended to make it in.
> >
> > My rationale is: why bother having av_restrict and not use it where it
> helps?
>
> sure if it helps lets use it, but does it for the following:
>  libavcodec/alpha/dsputil_alpha.c    |    4 ++--
>  libavcodec/alpha/dsputil_alpha.h    |    4 ++--
>  libavcodec/alpha/motion_est_alpha.c |    4 ++--
>  libavcodec/arm/dsputil_init_armv6.c |    2 +-
>  libavcodec/bfin/dsputil_bfin.h      |    2 +-
>  libavcodec/bfin/pixels_bfin.S       |    2 +-
>  libavcodec/ppc/dsputil_altivec.c    |    4 ++--
>
> ?
>
> i mean alpha/arm/bfin/ppc arent MSVC targets AFAIK
>
>
The latest iteration of MSVC has a ARM target, for their new Windows RT,
which runs on ARM phones/tablets.
Despite that, consistency seems also a proper reason to just change these
few cases.


More information about the ffmpeg-devel mailing list