[FFmpeg-devel] [PATCH]Sanitize VBR setting for libfdk-aac

[Derek Buitenhuis]

On 11/09/2012 4:46 PM, Carl Eugen Hoyos wrote:
>>> -        int mode = avctx->global_quality;
>>> +        int mode = avctx->global_quality / FF_QP2LAMBDA;
>>
>> I'm not really sure how this can be right.
> 
> Please elaborate how this is supposed to be done.

This doesn't make it better in any way. Nothing that uses global_quality uses
the same scale anyway, and libfdk-aac uses a discrete set of values from it. 
Using FF_QP2LAMBDA will only complicate and/or break this functionality.

- Derek