[FFmpeg-devel] [PATCH]Support more AVC-Intra files

[Tomas Härdin]

On Wed, 2012-09-26 at 12:13 +0200, Carl Eugen Hoyos wrote:
> Hi!
> 
> Followup to http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/151321
> Attached patch by Reimar and Thomas Mundt fixes some AVC-Intra files from 
> different tickets.
> It does not fix http://samples.ffmpeg.org/ffmpeg-
> bugs/trac/ticket524/AVCI50.mov
> 
> Please review, Carl Eugen


> +    if (!st->codec->extradata_size && st->codec->codec_id == AV_CODEC_ID_H264 &&
> +        st->codec->codec_tag != MKTAG('a', 'v', 'c', '1')) {
> +        ff_generate_avci_extradata(st);
> +    }
> +

You should perhaps add a comment here making it clear that this is done
for ai5q, ai52, ai55, ai1q, ai12 and ai15.

> +        if (descriptor->extradata) {
> +            st->codec->extradata = descriptor->extradata;
> +            st->codec->extradata_size = descriptor->extradata_size;
> +        } else {
> +            ff_generate_avci_extradata(st);
> +        }

Won't this generate extradata for all formats? Remember, MXF doesn't
store extradata except for unofficial extensions. You should inspect
codec_ul.

Looks like a reasonable solution overall - prettier than what I hacked
together at work.

Have you tested that these files still work in say FCP7 after being
remuxed to MOV? It might be necessary to strip SPS/PPS when muxing
AVC-Intra.

/Tomas