[FFmpeg-devel] [PATCH] ffprobe: add/extend disposition printing support

Stefano Sabatini stefasab at gmail.com
Sun Sep 30 12:27:33 CEST 2012


On date Saturday 2012-09-29 10:47:29 +0200, Stefano Sabatini encoded:
> On date Saturday 2012-09-29 00:12:01 +0200, Clément Bœsch encoded:
[...]
> > > +    } while (0)
> > > +
> > > +    PRINT_DISPOSITION(DEFAULT,          "default");
> > > +    PRINT_DISPOSITION(DUB,              "dub");
> > > +    PRINT_DISPOSITION(ORIGINAL,         "original");
> > > +    PRINT_DISPOSITION(COMMENT,          "comment");
> > > +    PRINT_DISPOSITION(LYRICS,           "lyrics");
> > > +    PRINT_DISPOSITION(KARAOKE,          "karaoke");
> > > +    PRINT_DISPOSITION(FORCED,           "forced");
> > > +    PRINT_DISPOSITION(HEARING_IMPAIRED, "hearing_impaired");
> > > +    PRINT_DISPOSITION(VISUAL_IMPAIRED,  "visual_impaired");
> > > +    PRINT_DISPOSITION(CLEAN_EFFECTS,    "clean_effects");
> > > +    PRINT_DISPOSITION(ATTACHED_PIC,     "attached_pic");
> > > +    writer_print_section_footer(w);
> > > +
> > 
> > Would it make sense to use WRITER_FLAG_DISPLAY_OPTIONAL_FIELDS to avoid
> > printing a lot of zero entries when unnecessary?
> 
> I thought about that. My conclusion is that a missing field means
> "unspecified/unavailable", in this case all the values are specified
> and are set to 0/1.
[...]

Applied.
-- 
FFmpeg = Fanciful Friendly Mortal Prodigious Ephemeral Guide


More information about the ffmpeg-devel mailing list