[FFmpeg-devel] [PATCH]Skip padding when reading id3 tags in aiff

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Apr 3 22:05:22 CEST 2013


Matthieu Bouron <matthieu.bouron <at> gmail.com> writes:

> > +    if (position + size > avio_tell(pb))
> > +        avio_skip(pb, position + size - avio_tell(pb));

> The test could have been if (avio_tell(pb) & 1) avio_skip(1); 
> since AIFF chunks must be even aligned. I tend to prefer this 
> check however maybe it's better to skip extra padding ?

I thought there may be extra padding and it does not hurt 
to skip it but I may be wrong...

> The patch is OK though.

Michael merged this patch.

Thank you, Carl Eugen



More information about the ffmpeg-devel mailing list