[FFmpeg-devel] [PATCH v2] lavfi: port IVTC filters from vapoursynth.

Clément Bœsch ubitux at gmail.com
Sun Apr 14 16:03:07 CEST 2013


On Wed, Apr 10, 2013 at 08:15:13AM +0000, Paul B Mahol wrote:
[...]
> > +static int query_formats(AVFilterContext *ctx)
> > +{
> > +    static const enum AVPixelFormat pix_fmts[] = {
> > +        AV_PIX_FMT_YUV444P,  AV_PIX_FMT_YUV422P,  AV_PIX_FMT_YUV420P,
> > +        AV_PIX_FMT_YUV411P,  AV_PIX_FMT_YUV410P,
> > +        AV_NE(AV_PIX_FMT_YUV420P9BE,  AV_PIX_FMT_YUV420P9LE),
> > +        AV_NE(AV_PIX_FMT_YUV422P9BE,  AV_PIX_FMT_YUV422P9LE),
> > +        AV_NE(AV_PIX_FMT_YUV444P9BE,  AV_PIX_FMT_YUV444P9LE),
> > +        AV_NE(AV_PIX_FMT_YUV420P10BE, AV_PIX_FMT_YUV420P10LE),
> > +        AV_NE(AV_PIX_FMT_YUV422P10BE, AV_PIX_FMT_YUV422P10LE),
> > +        AV_NE(AV_PIX_FMT_YUV444P10BE, AV_PIX_FMT_YUV444P10LE),
> > +        AV_NE(AV_PIX_FMT_YUV420P12BE, AV_PIX_FMT_YUV420P12LE),
> > +        AV_NE(AV_PIX_FMT_YUV422P12BE, AV_PIX_FMT_YUV422P12LE),
> > +        AV_NE(AV_PIX_FMT_YUV444P12BE, AV_PIX_FMT_YUV444P12LE),
> > +        AV_NE(AV_PIX_FMT_YUV420P14BE, AV_PIX_FMT_YUV420P14LE),
> > +        AV_NE(AV_PIX_FMT_YUV422P14BE, AV_PIX_FMT_YUV422P14LE),
> > +        AV_NE(AV_PIX_FMT_YUV444P14BE, AV_PIX_FMT_YUV444P14LE),
> > +        AV_NE(AV_PIX_FMT_YUV420P16BE, AV_PIX_FMT_YUV420P16LE),
> > +        AV_NE(AV_PIX_FMT_YUV422P16BE, AV_PIX_FMT_YUV422P16LE),
> > +        AV_NE(AV_PIX_FMT_YUV444P16BE, AV_PIX_FMT_YUV444P16LE),
> 
> gray and alpha versions of those above; also what about planar gbrp
> (or even interleaved one)?
> 

Added alpha versions. But, for now I keep the filter YUV-based only. Feel
free to send patches to add more.

[...]
> It would be extra if you did run it under valgrind and similar and it did not do
> any of uninitialized reads, overreads and overwrites.

I use valgrind during development, so there is no such known problem.
There was a little leak with the pad names though, which I fixed.

Patch applied, thanks.

-- 
Clément B.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 490 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130414/ac9be0da/attachment.asc>


More information about the ffmpeg-devel mailing list