[FFmpeg-devel] [PATCH] colormixer filter

[Lou Logan]

On Mon, 15 Apr 2013 20:33:12 +0000, Paul B Mahol wrote:

> Signed-off-by: Paul B Mahol <onemda at gmail.com>
> ---
>  doc/filters.texi            |  23 ++++++
>  libavfilter/Makefile        |   1 +
>  libavfilter/allfilters.c    |   1 +
>  libavfilter/vf_colormixer.c | 165 ++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 190 insertions(+)
>  create mode 100644 libavfilter/vf_colormixer.c
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 178dbe5..eec836b 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -2135,6 +2135,29 @@ For example to convert from BT.601 to SMPTE-240M, use the command:
>  colormatrix=bt601:smpte240m
>  @end example
>  
> + at section colormixer

channelmixer seems to be a more common name among other tools (Gimp,
Photoshop, Premiere).

> +This filter adjust video input frame by re-mixing its color channels.

This filter adjusts video input frames by re-mixing color channels.

Alternate:
This filter adjusts values of RGB color channels.

> +The filter accepts the following options:
> +
> + at table @option
> + at item rr
> + at item rg
> + at item rb
> +Adjust contribution of input red, green and blue channel to output red channel.

Adjust contribution of input red, green and blue channels for output red
channel.

Description of valid range and a usage example would be nice (my syntax
may be wrong):

Grayscale RGB
channelmixer=rr=21:rg=72:rb=7:gr=21:gb=72:gb=7:br=21:bg=72:bg=7

Might be another filter good for a few presets like the curves filter.

Rest of doc stuff LGTM.