[FFmpeg-devel] [PATCH] lavfi/hue: fix h/H commands in case h and H are not specified as initial parameters

Stefano Sabatini stefasab at gmail.com
Tue Apr 23 22:55:35 CEST 2013


On date Monday 2013-04-22 01:16:55 +0200, Clément Bœsch encoded:
> On Sun, Apr 21, 2013 at 05:33:33PM +0200, Stefano Sabatini wrote:
> > In filter_frame(), check for the existence of the corresponding parsed
> > expression rather than on the expression, which may or may not be set,
> > and release the alternative parsed expression when one of H/h is set.
> > ---
> >  libavfilter/vf_hue.c |   31 ++++++++++++++++++++-----------
> >  1 file changed, 20 insertions(+), 11 deletions(-)
[...]
> LGTM
> 
> Note: you could also av_freep() the opposite expression strings in the h/H
> command case to avoid inconsistent context states and the first diff
> chunks of that patch.

Extended in order to update the expression as well (unfortunately more
complex), and pushed.
-- 
FFmpeg = Furious and Fundamentalist Magnificient Picky Elastic Genius


More information about the ffmpeg-devel mailing list