[FFmpeg-devel] [PATCH]Add little-endian G726 decoder and use it for Sun AU files

Michael Niedermayer michaelni at gmx.at
Thu Aug 1 22:41:01 CEST 2013

On Thu, Jul 11, 2013 at 12:57:00PM +0000, Paul B Mahol wrote:
> On 7/11/13, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> > Hi!
> >
> > Attached patch fixes ticket #1955 as suggested by Roman.
> >
> > Please comment, Carl Eugen
> >
> There is way to check if given decoded audio is sane enough, using fft
> one can inspect first be variant and then le one and pick one with
> higher score. This is actually used in reality for at least one case I
> can't remember right now.
> This one we can avoid having another decoder.
> Anyway having another decoder is really ugly, you could make use of
> extradata to have/force same funcionality.

whats the status of this patch & thread ?

The way i understand it is that carls patch is implemented in line
with a suggestion from roman (who is maintainer of g726) but he didnt
explicitly approve this patch though.

It was suggested (above) that extradata could be used to avoid the 2nd
dummy AVCodec, I see advantages and disadvantages of such approuch
and dont really mind which way its done but i do mind if neither
solution is pushed.
If roman makes an explicit statement about this patch vs extradata
then i will follow his choice if he does not i will eventually push
one solution as either is better than having no support.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

You can kill me, but you cannot change the truth.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130801/ca9d46de/attachment.asc>

More information about the ffmpeg-devel mailing list