[FFmpeg-devel] [PATCH] lavc: make invalid UTF-8 in subtitle output a non-fatal error

Michael Niedermayer michaelni at gmx.at
Thu Aug 8 16:32:22 CEST 2013


On Thu, Aug 08, 2013 at 04:22:31PM +0200, Nicolas George wrote:
> Le primidi 21 thermidor, an CCXXI, Michael Niedermayer a écrit :
> > i maintain multiple fate clients that have no iconv, not that it
> > matters much for the discussion here
> 
> libiconv can not be installed?

IIRC it was qemu based stuff so installing would equate (cross)
building (and all its dependancies). I dont know how much work that
would be
if someone else wants to maintain the affected virtual fate boxes
and build or find iconv for them ...


> 
> To compare with what I believe is a similar situation, some of the supported
> formats are seriously crippled without libz, and nobody considers it a
> problem.

> > If theres a developer who wants/needs a feature and is willing to
> > implement & maintain it then i will merge his work. (given its clean,
> > not buggy and iam aware of its existence and all that)
> > 
> > (there are a few corner cases where i wont but "returning the data as
> >  it is without mangling" (invalid if thats how it is)) is not one of
> > them
> > 
> > No developer should be able to block anothers work.
> > I thought disros like debian had such a rule and wanted to quote it
> > but seems i cant find it. Doesnt matter as i can speak myself what i
> > mean and i hope/belive thats a "rule" almost everyone agrees with.
> 
> Of course. But if they consider something a bad idea, they are allowed to
> make it known, especially if they suggest a better solution at the same
> time.

yes of course


> 
> Also, note that loosening the constraints on returned data can be considered
> an API break, possibly with security consequences (applications may trust
> the returned data without validating it again). I do not think this case is
> as bad as that, but still, a possible API break is something that needs to
> be discussed.

yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130808/434e6a69/attachment.asc>


More information about the ffmpeg-devel mailing list