[FFmpeg-devel] [PATCH] lavf/wavdec: Fix seeking in files with unaligned offsets

[Alexander Strasser]

Hi Matthieu!

On 2013-08-14 10:51 +0100, Matthieu Bouron wrote:
> On Tue, Aug 13, 2013 at 6:10 PM, Alexander Strasser <eclipse7 at gmx.net>wrote:
> 
> > A file with a prepended ID3 tag of an uneven length was found
> > in the wild.
> >
> > Check if the wav data starts at an uneven offset and use that
> > information to correct the seeking calculation in wav_seek_tag,
> > which used to only seek to even byte positions.
> >
> > Regression since ac87eaf856e0fb51917266b899bb15d19b907baf
[patch]
> 
> LGTM.
> Adding a fate test for this could be a good idea.

  Pushed. Thank you for the review!

  Would not hurt to have a test for this. I will look into adding
a small fate test next week.


> Are there a lot of samples like this ?

  At least the reporter of this regression has some more.

  Alexander
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130814/40cd1d3b/attachment.asc>