[FFmpeg-devel] [PATCH] matroskadec: Fix TTA duration calculation

James Almer jamrial at gmail.com
Thu Aug 15 22:16:55 CEST 2013


On 15/08/13 9:00 AM, Michael Niedermayer wrote:
> On Thu, Aug 15, 2013 at 10:44:27AM +0000, Paul B Mahol wrote:
>> On 8/15/13, Michael Niedermayer <michaelni at gmx.at> wrote:
>>> On Thu, Aug 15, 2013 at 06:22:47AM -0300, James Almer wrote:
>>>> Still not perfect due to rounding errors, but several samples should
>>>> demux correctly now instead of none.
>>>
>>> please add a link to a sample to reproduce this bugfix in the commit
>>> message
>>
>> Samples are not needed at all, this can be easily reproduced.
> 
> then the commit message should contain a reproducable testcase
> Having such testcases can simplify my work maintaining matroskadec

I'll resubmit the patch with a testcase using a sample from the FATE suit
and a different commit message since, as Paul said, it doesn't fix the 
calculation but improves it.

Regards.


More information about the ffmpeg-devel mailing list