[FFmpeg-devel] [PATCH] avformat/redspark: check coef_off

[Michael Niedermayer]

Fixes out of array reads

Found-by: Laurent Butti <laurentb at gmail.com>
Signed-off-by: Michael Niedermayer <michaelni at gmx.at>
---
 libavformat/redspark.c |    5 +++++
 1 file changed, 5 insertions(+)

diff --git a/libavformat/redspark.c b/libavformat/redspark.c
index 44d5da7..3963261 100644
--- a/libavformat/redspark.c
+++ b/libavformat/redspark.c
@@ -108,6 +108,11 @@ static int redspark_read_header(AVFormatContext *s)
     if (bytestream2_get_byteu(&gbc)) // Loop flag
         coef_off += 16;
 
+    if (coef_off + codec->channels * (32 + 14) > HEADER_SIZE) {
+        ret = AVERROR_INVALIDDATA;
+        goto fail;
+    }
+
     codec->extradata_size = 32 * codec->channels;
     codec->extradata = av_malloc(codec->extradata_size);
     if (!codec->extradata) {
-- 
1.7.9.5