[FFmpeg-devel] [PATCH] avformat: export probe score

Nicolas George nicolas.george at normalesup.org
Tue Aug 27 23:33:07 CEST 2013

Le decadi 10 fructidor, an CCXXI, Michael Niedermayer a écrit :
> honestly it never made sense, these all represent fields of structures
> not code setting or getting anything.

I think I agree.

> the API is complex enough as it is, no need for more wraper functions
> but iam not stoping anyone from adding such functions if someone wants

OTOH, accessors are checked at build time: if a field change name, or type,
or whatever, and some piece of code is not updated accordingly, that will
probably give a warning or a build failure. With an option, it may give a
run-time error, an inconsistent value or a NULL pointer deref.

I am not saying that using accessors catches all mistakes, but it catches a
lot more than options.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130827/f2998eb0/attachment.asc>

More information about the ffmpeg-devel mailing list