[FFmpeg-devel] [PATCH] libavcodec: Do not return encoding errors when -sub_charenc_mode is do_nothing

[Nicolas George]

Le tridi 13 fructidor, an CCXXI, Eelco Lempsink a écrit :
> Hmm, sorry, that’s not the solution I’m looking for.  I want something so
> that I can just pass in an SRT file and FFmpeg will figure out the
> encoding.  

> It’s very important to realize that character encoding detection is not
> something that can be done in an exact matter.

I believe you are contradicting yourself: "I want X... X is not possible".

I have no objection to someone implementing optional support for smarter
heuristics, possibly using external libraries.

The default behaviour need to be simple enough to be predictable and
controllable by the users, though.

> I would expect the Matroska muxer to enforce that, not the decoder.

A muxer has no business examining the payload data of packets. It would be
its task to check that the declared encoding is acceptable, but setting the
declared encoding is the encoder's task, and the encoder can not be blamed
to produce invalid packets if fed with invalid input.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20130830/5fb898fd/attachment.asc>