[FFmpeg-devel] [PATCH] lavfi: add aeval filter

Lou Logan lou at lrcd.com
Thu Dec 5 22:39:44 CET 2013


On Thu, 5 Dec 2013 19:06:45 +0100, Stefano Sabatini wrote:

> From 479a8fb99ba91a939a0b3faf18865ac05bde0b14 Mon Sep 17 00:00:00 2001
> From: Stefano Sabatini <stefasab at gmail.com>
> Date: Mon, 2 Dec 2013 17:58:41 +0100
> Subject: [PATCH] lavfi: add aeval filter
> 
> ---
>  doc/filters.texi            |  69 ++++++++++++++++
>  libavfilter/Makefile        |   1 +
>  libavfilter/allfilters.c    |   1 +
>  libavfilter/asrc_aevalsrc.c | 188 ++++++++++++++++++++++++++++++++++++++++++--
>  4 files changed, 251 insertions(+), 8 deletions(-)
> 
> diff --git a/doc/filters.texi b/doc/filters.texi
> index 2a2fd50..b084118 100644
> --- a/doc/filters.texi
> +++ b/doc/filters.texi
> @@ -435,6 +435,75 @@ aecho=0.8:0.9:1000|1800:0.3|0.25
>  @end example
>  @end itemize
>  
> + at section aeval
> +
> +Modify an audio signal according to the specified expression.
> +
> +This filter accepts in input one or more expressions (one for each
> +channel), which are evaluated and used to modify a corresponding audio
> +signal.

Nit: The "in input" is confusing to me. Or maybe it just seems
redundant. Does it make sense to just say, "This filter accepts one or
more..."?

The rest LGTM.


More information about the ffmpeg-devel mailing list